Fix URL in FutureWarning for .loc[list-of-labels] with missing labels #19145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you know if sphinx let's you have multiple labels for the same header? It'd be nice to add a in the same spot, so that both URLs point to the same spot. |
jschendel
force-pushed
the
loc-listlike-url
branch
from
abf4652 to
ef0bd29
Compare
Yeah, was wondering that myself since it seems like it'd be a nicer solution to just make the URL work than to change it. Had to try a few variations, but eventually got the second label working, at least for my local build of the docs. No real point in changing to URL in this case; I'll make it https but leave everything else as is. Assuming this is fine, will check the docs generated by travis after this gets merged to make sure it's working there too. |
|
thanks! |
maximveksler
pushed a commit
to maximveksler/pandas
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff